Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 110 110
Lines 17588 17582 -6
Branches 1515 1515
=========================================
- Hits 17588 17582 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ide
approved these changes
Apr 2, 2026
wschurman
force-pushed
the
wschurman/04-01-fix_remove_unnecessary_returning_from_database_adapter_update
branch
from
50f5f25 to
10a0a44
Compare
wschurman
deleted the
wschurman/04-01-fix_remove_unnecessary_returning_from_database_adapter_update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When reviewing #540, I noticed that the
RETURNING *isn't necessary, even in the normal case (since #233).How
Remove the
RETURNING *, return a simple updatedRowCount instead for error behavior.Test Plan
Run tests.